Remove docker from QGIS tests #943
Conversation
Use local pytest instead. Had to remove the two tests that really instantiate the GUI.
There was a problem hiding this comment.
This is akin to removing tests because they fail, instead of fixing them. Especially the first removed test (plugin load) seems essential for guaranteeing the QGIS plugin will work. Note that the remaining plugins purely tests internal consistency of code (syntax mostly), not whether it is a valid plugin at all.
|
I guess this can be closed in favor of #939. Still would be nice to be able to drop Docker from our test stack, given we have QGIS in our Pixi environment as well, but preferably not at the cost of reduced testing capability. |
Since the latest attempt also didn't fix it, maybe we merge this and add a high priority issue to add something equivalent with pixi? Or does anyone want to give docker another try? |
Yeah, I have given up on the Docker path (although I don't expect it is the root cause), but I can try the pixi path in this branch. |
|
Make sure to merge main, which has a more recent QGIS that is not broken. |
Windows and Linux should be the same QGIS plugins are now installed as user plugins within the environment, and not as core plugins.
|
…s-tests # Conflicts: # .docker/compose.yml # .docker/start.sh # .docker/test.sh # .github/workflows/qgis.yml # ribasim_qgis/tests/test_load_plugin.py
|
I can't run the tests locally because of qgis/QGIS#52987 on mac, but it seems to be setup ok. 👍🏻 |
The tests are now run via the qgis_testrunner script that is a clone from the original QGIS runner: https://github.com/qgis/QGIS/blob/4891c6bda8922ff5c6a70021f097ce43c486cddf/.docker/qgis_resources/test_runner/qgis_testrunner.py. I removed the if check for being inside or outside of QGIS, because not every module was available in Windows.
The QGIS profile information and the plugins themselves are now installed inside of the .pixi folder, so that cleanup is easier. And there is no need anymore for looking into the roaming folder.
The QGIS tests that really require the user interface are called via
test-ribasim-qgis-ui. This task is not automated.The QGIS tests that do not require the user interface are called via
test-ribasim-qgisand are automated via github actions.